Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support promolecules with single atom #135

Merged
merged 4 commits into from
Dec 16, 2024
Merged

Support promolecules with single atom #135

merged 4 commits into from
Dec 16, 2024

Conversation

msricher
Copy link
Collaborator

@msricher msricher commented Dec 9, 2024

Fixes #134

Copy link
Member

@PaulWAyers PaulWAyers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @msricher . I'd like to get @marco-2023 and/or @gabrielasd 's feedback too, but it looks good to me.

Copy link
Member

@PaulWAyers PaulWAyers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't we need to do the same trick for charges/mults in lines 582-592?

@msricher
Copy link
Collaborator Author

Yep you're right. I didn't think about both of those also being single values.

Copy link
Member

@PaulWAyers PaulWAyers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. @marco-2023 and/or @gabrielasd

Copy link
Collaborator

@gabrielasd gabrielasd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good to me too.

@msricher could you add a test case for this fix to test_promolecule.py
It could be a slight change of this test case in the module:

pytest.param(
{
"atnums": [4],
"charges": [1.2],
"mults": [1.2],
"coords": np.asarray(

@gabrielasd
Copy link
Collaborator

I don't think this is related to the changes Michelle introduced, but the CI checks are failing when building the website.

It mentions an incompatibility between Scipy library and python version. This doesn't make sense to me since the rest of the checks for different python envs are passing.
It could be that the Scipy version listed here differs from the one in the pyproject.toml, but I am not sure.

@msricher or @marco-2023 could you look into this?

@FanwangM
Copy link
Contributor

FanwangM commented Dec 15, 2024

I am not familiar with the technical part, but the failing test is fixed now.
@PaulWAyers @msricher @marco-2023 @gabrielasd

@PaulWAyers
Copy link
Member

We used to limit the top version of Scipy because we were using its old-fashioned generalized inverse. We don't use that anymore (and probably not at all in this package) so this is a good update on the dependencies.

@msricher msricher merged commit 511a702 into master Dec 16, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support promolecules with only one atom
5 participants