Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#82 Update genciwfn.cpp #91

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

pm-235779
Copy link

Issue Details

File: genciwfn.cpp - Line: 46
Incorrect Variable: nword2
Correct Variable: nword
Code Before Correction
k += wfn.nword2;

Code After Correction
k += wfn.nword;

Issue Details

File: genciwfn.cpp - Line: 46
Incorrect Variable: nword2
Correct Variable: nword
Code Before Correction
k += wfn.nword2;

Code After Correction
k += wfn.nword;
@msricher
Copy link
Collaborator

msricher commented Jan 6, 2025

Hi, I'll address this after @q-pratz-chem uploads her PR which uses GenCIWfn extensively. She has probably fixed this in the meantime.

@pm-235779
Copy link
Author

Hi, I'll address this after @q-pratz-chem uploads her PR which uses GenCIWfn extensively. She has probably fixed this in the meantime.

ok ill wait till then

@q-pratz-chem
Copy link
Collaborator

Hi, I'll address this after @q-pratz-chem uploads her PR which uses GenCIWfn extensively. She has probably fixed this in the meantime.

ok ill wait till then

Hi, I fixed it to use the GenCIWfn as a base class for the NonSingletCI class. I will make a PR collectively for the NonSingletCI and geminal wavefunction implementation, which includes a fix for this issue as well.

@pm-235779
Copy link
Author

Hi @msricher ,

Since you mentioned that @q-pratz-chem PR should be merged first, could you please let me know if I should proceed with any changes on my end, or wait until her PR is merged? Happy to coordinate accordingly.

Best regards,
@pm-235779

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants