Add support for MaxSum and DISE Algorithm
#220
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…orithm-interface
|
I am trying to reduce the size of each PR. This one is large because we haven't merge the one before: #212. Once that one is merged, the lines of code will greatly reduced for easier review. |
JackyZzZz
changed the title
MaxSum and DISE Algorithm
FanwangM
changed the title
MaxSum and DISE AlgorithmMaxSum and DISE Algorithm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces the interface for the
MaxSumandDISEalgorithm. It also optimizes the overall codebase structure since a lot of the codeupload_matrixandexport_resultcan be reused.The demo of the PR is live on HuggingFace.