-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Made one dimensional grids notebook #201
Conversation
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
BeckeRTransform of certain OneDGrids with points at 1.0 (like Trapezoidal) resulted in RuntimeWarning: divide by zero encountered in deriv and deriv2 methods. To avoid printing a warning message, the zero devision was disabled.
To simply tutorials and make it easier to keep track of the name of 1-dimensional grids, name was added as a class attribute.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @marco-2023. The 3 commits above include my changes/updates; let me know if you have any questions. I have no further comments at this point.
- Add relative error for [0, infty) integration - Added log plot to one of the plots
for more information, see https://pre-commit.ci
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. I've added a subplot including a log plot for the radial grid transformation and added relative error as well to the radial grid transformation.
No description provided.