Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare for pypi publish #27

Merged
merged 6 commits into from
Aug 28, 2023
Merged

Prepare for pypi publish #27

merged 6 commits into from
Aug 28, 2023

Conversation

Wirg
Copy link
Collaborator

@Wirg Wirg commented Aug 25, 2023

  • fix build config folder
  • add some descriptors
  • bump version for preprelease
  • fix README.md to work on pypi (absolute url)
  • move most of genoss-server main to genoss folder to integrate it into the final package
  • create a genoss-server entrypoint and update doc

@github-actions
Copy link

Risk Level 2 - /home/runner/work/GenossGPT/GenossGPT/genoss/default_server.py

The code is generally well written, but there is a potential issue with error handling. In the validation_exception_handler function, the error message is being logged and returned in the response. This could potentially expose sensitive information. Consider sanitizing the error message before returning it in the response. For example:

exc_str = sanitize_error_message(f\"{exc}\")

Where sanitize_error_message is a function that removes sensitive information from the error message.


📝🔒⚠️


Powered by Code Review GPT

@StanGirard StanGirard merged commit 35afd30 into main Aug 28, 2023
@StanGirard StanGirard deleted the fix-install branch August 28, 2023 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants