Accept arrays of entities (#218)

Co-authored-by: titiyoyo <[email protected]> Co-authored-by: Terence <[email protected]>
theofidry · Jul 2, 2022 · 1ba759a · 1ba759a
1 parent 3bf17a5
commit 1ba759a
Show file tree

Hide file tree

Showing 5 changed files with 46 additions and 1 deletion.
diff --git a/composer.json b/composer.json
@@ -25,6 +25,7 @@
         "webmozart/assert": "^1.10"
     },
     "require-dev": {
+        "doctrine/annotations": "^1.13",
         "bamarni/composer-bin-plugin": "^1.4.1",
         "phpspec/prophecy": "^1.14.0",
         "phpspec/prophecy-phpunit": "^2.0.1",

diff --git a/fixtures/Bridge/Symfony/Entity/Group.php b/fixtures/Bridge/Symfony/Entity/Group.php
@@ -45,4 +45,9 @@ public function addUser(User $user): void
             $this->users->add($user);
         }
     }
+
+    public function getUsers(): Collection
+    {
+        return $this->users;
+    }
 }
diff --git a/fixtures/fixture_files/user_group_array.yml b/fixtures/fixture_files/user_group_array.yml
@@ -0,0 +1,21 @@
+#
+# This file is part of the Fidry\AliceDataFixtures package.
+#
+# (c) Théo FIDRY <[email protected]>
+#
+# For the full copyright and license information, please view the LICENSE
+# file that was distributed with this source code.
+#
+
+Fidry\AliceDataFixtures\Bridge\Symfony\Entity\User:
+    user{1..5}:
+        groups: '<numberBetween(2, 5)>x @group*'
+
+Fidry\AliceDataFixtures\Bridge\Symfony\Entity\Group:
+    group{1..5}:
+        users:
+            - '@user1'
+            - '@user2'
+            - '@user3'
+            - '@user4'
+            - '@user5'
diff --git a/src/Bridge/Doctrine/Persister/ObjectManagerPersister.php b/src/Bridge/Doctrine/Persister/ObjectManagerPersister.php
@@ -150,7 +150,11 @@ private function checkAssociationsMetadata(ORMClassMetadataInfo $metadata, objec
             $targetEntityClassName = $associationMapping['targetEntity'];
             $fieldValueOrFieldValues = $metadata->getFieldValue($object, $fieldName);
 
-            if ($fieldValueOrFieldValues instanceof Collection) {
+            if (is_array($fieldValueOrFieldValues)) {
+                foreach ($fieldValueOrFieldValues as $fieldValue) {
+                    $this->getMetadata($targetEntityClassName, $fieldValue);
+                }
+            } elseif ($fieldValueOrFieldValues instanceof Collection) {
                 foreach ($fieldValueOrFieldValues->getValues() as $fieldValue) {
                     $this->getMetadata($targetEntityClassName, $fieldValue);
                 }

diff --git a/tests/Bridge/Symfony/Doctrine/ORMLoaderIntegrationTest.php b/tests/Bridge/Symfony/Doctrine/ORMLoaderIntegrationTest.php
@@ -112,6 +112,20 @@ public function testBidirectionalRelationships(): void
         self::assertCount(5, $groups);
     }
 
+    public function testArrayRelationships(): void
+    {
+        $this->loader->load([
+            __DIR__.'/../../../../fixtures/fixture_files/user_group_array.yml',
+        ]);
+
+        $users = $this->doctrine->getRepository(User::class)->findAll();
+        $groups = $this->doctrine->getRepository(Group::class)->findAll();
+
+        self::assertCount(5, $users);
+        self::assertCount(5, $groups);
+        self::assertCount(5, $groups[0]->getUsers());
+    }
+
     public function testBidirectionalRelationshipsDeclaredInDifferentFiles(): void
     {
         $this->loader->load([