Skip to content

fix EnvironmentName str interpolation #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fix EnvironmentName str interpolation #3

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ee3dc51
updating string interpolation
dupontz Oct 11, 2023
65726c3
updating tests
dupontz Oct 12, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions ecs-runtask.cfndsl.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,12 +88,12 @@
end
Events_Rule(:Schedule) do
Name FnSub("${EnvironmentName}-#{component_name}-eventrule")
Description FnSub("{EnvironmentName} #{component_name} eventrule")
Description FnSub("${EnvironmentName} #{component_name} eventrule")
ScheduleExpression schedule unless schedule.nil?
EventPattern FnSub(event_pattern) unless event_pattern.nil?
Targets [{
Arn: Ref(:StateMachine),
Id: FnSub("{EnvironmentName}-#{component_name}-target"),
Id: FnSub("${EnvironmentName}-#{component_name}-target"),
RoleArn: FnGetAtt('EventBridgeInvokeRole', 'Arn')
}]
end
Expand Down
4 changes: 2 additions & 2 deletions spec/event_pattern_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,15 +105,15 @@
end

it "to have property Description" do
expect(resource["Properties"]["Description"]).to eq({"Fn::Sub"=>"{EnvironmentName} ecs-runtask eventrule"})
expect(resource["Properties"]["Description"]).to eq({"Fn::Sub"=>"${EnvironmentName} ecs-runtask eventrule"})
end

it "to have property EventPattern" do
expect(resource["Properties"]["EventPattern"]).to eq({"Fn::Sub"=>"{\n \"source\": [\"aws.cloudformation\"],\n \"detail-type\": [\"CloudFormation Stack Status Change\"],\n \"resources\": [\"arn:aws:cloudformation:us-west-2:123456789012:stack/dev-stack\"]\n}"})
end

it "to have property Targets" do
expect(resource["Properties"]["Targets"]).to eq([{"Arn"=>{"Ref"=>"StateMachine"}, "Id"=>{"Fn::Sub"=>"{EnvironmentName}-ecs-runtask-target"}, "RoleArn"=>{"Fn::GetAtt"=>["EventBridgeInvokeRole", "Arn"]}}])
expect(resource["Properties"]["Targets"]).to eq([{"Arn"=>{"Ref"=>"StateMachine"}, "Id"=>{"Fn::Sub"=>"${EnvironmentName}-ecs-runtask-target"}, "RoleArn"=>{"Fn::GetAtt"=>["EventBridgeInvokeRole", "Arn"]}}])
end

end
Expand Down
4 changes: 2 additions & 2 deletions spec/schedule_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,15 +105,15 @@
end

it "to have property Description" do
expect(resource["Properties"]["Description"]).to eq({"Fn::Sub"=>"{EnvironmentName} ecs-runtask eventrule"})
expect(resource["Properties"]["Description"]).to eq({"Fn::Sub"=>"${EnvironmentName} ecs-runtask eventrule"})
end

it "to have property ScheduleExpression" do
expect(resource["Properties"]["ScheduleExpression"]).to eq("* * * * *")
end

it "to have property Targets" do
expect(resource["Properties"]["Targets"]).to eq([{"Arn"=>{"Ref"=>"StateMachine"}, "Id"=>{"Fn::Sub"=>"{EnvironmentName}-ecs-runtask-target"}, "RoleArn"=>{"Fn::GetAtt"=>["EventBridgeInvokeRole", "Arn"]}}])
expect(resource["Properties"]["Targets"]).to eq([{"Arn"=>{"Ref"=>"StateMachine"}, "Id"=>{"Fn::Sub"=>"${EnvironmentName}-ecs-runtask-target"}, "RoleArn"=>{"Fn::GetAtt"=>["EventBridgeInvokeRole", "Arn"]}}])
end

end
Expand Down