Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add s3 website alias record #27

Merged
merged 1 commit into from
Dec 13, 2023
Merged

feat: add s3 website alias record #27

merged 1 commit into from
Dec 13, 2023

Conversation

raykrishardi
Copy link
Contributor

No description provided.

tarunmenon95
tarunmenon95 approved these changes Dec 13, 2023
View reviewed changes
Copy link
Contributor

@tarunmenon95 tarunmenon95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@tarunmenon95 tarunmenon95 merged commit 5b0cd73 into theonestack:master Dec 13, 2023
1 check failed
@tarunmenon95 tarunmenon95 deleted the feature/s3-website-alias branch December 13, 2023 06:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tarunmenon95 tarunmenon95 tarunmenon95 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@raykrishardi @tarunmenon95