Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[GEN AI] Improving Langfuse's traces #1793

Merged
merged 3 commits into from
Jan 10, 2025
Merged

[GEN AI] Improving Langfuse's traces #1793

merged 3 commits into from
Jan 10, 2025

Conversation

assouktim
Copy link
Contributor

@assouktim assouktim commented Nov 22, 2024 •
edited
Loading

Add dialogs details to Langfuse trace & Return Langfuse trace (id, name, url) in RAG Response

@assouktim assouktim marked this pull request as ready for review November 22, 2024 15:46
@assouktim assouktim force-pushed the featur/dercbot-langfuse-xxx branch from a4222d9 to 1878fe2 Compare November 22, 2024 15:46
@assouktim assouktim self-assigned this Nov 22, 2024
@assouktim assouktim changed the title [GEN AI] Improving Langfuse's tracks [GEN AI] Improving Langfuse's traces Nov 22, 2024
Benvii
Benvii requested changes Dec 3, 2024
View reviewed changes
Copy link
Member

@Benvii Benvii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this PR, ok for me juste added some suggestions and reflexions about our callback integration approach, if you agree I will create an other ticket for that I thing our current observability integration needs to be updated.

...hestrator-server/src/main/python/server/src/gen_ai_orchestrator/routers/requests/requests.py Outdated Show resolved Hide resolved
...hestrator-server/src/main/python/server/src/gen_ai_orchestrator/routers/requests/requests.py Outdated Show resolved Hide resolved
...hestrator-server/src/main/python/server/src/gen_ai_orchestrator/routers/requests/requests.py Outdated Show resolved Hide resolved
...hestrator-server/src/main/python/server/src/gen_ai_orchestrator/routers/requests/requests.py Outdated Show resolved Hide resolved
...main/python/server/src/gen_ai_orchestrator/services/langchain/factories/langchain_factory.py Show resolved Hide resolved
@assouktim assouktim force-pushed the featur/dercbot-langfuse-xxx branch 3 times, most recently from c49bc63 to 6072ada Compare December 4, 2024 13:13
@rkuffer rkuffer mentioned this pull request Dec 5, 2024
Merged
@Benvii Benvii mentioned this pull request Jan 10, 2025
Open
Benvii
Benvii approved these changes Jan 10, 2025
View reviewed changes
Copy link
Member

@Benvii Benvii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the updates ok for me.

@Benvii
Copy link
Member

Benvii commented Jan 10, 2025

I'm rebasing it and fixing the conflits and I will merge it.

@Benvii Benvii force-pushed the featur/dercbot-langfuse-xxx branch from 8603a08 to 3d7466c Compare January 10, 2025 13:57
@scezen scezen self-requested a review January 10, 2025 14:00
@Benvii Benvii merged commit 066e7c0 into theopenconversationkit:master Jan 10, 2025
@Benvii Benvii deleted the featur/dercbot-langfuse-xxx branch January 10, 2025 14:01
@vsct-jburet vsct-jburet added this to the 24.9.6 milestone Jan 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@scezen scezen scezen approved these changes

@Benvii Benvii Benvii approved these changes

Assignees

@assouktim assouktim

Labels
enhancement
Projects
CreditMutuelArkea backlog
Status: Done
Milestone
24.9.6
Development

Successfully merging this pull request may close these issues.
4 participants
@assouktim @Benvii @scezen @vsct-jburet