[DERCBOT-1385] Do not retrieve “Inboxed” phrases with FAQ questions. #1835
+9
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Benvii
requested changes
Feb 10, 2025
| ), | ||
| ne from listOf( | ||
| ClassifiedSentence::status, | ||
| ClassifiedSentenceStatus.inbox |
There was a problem hiding this comment.
Why not explicitly getting validated and model ? I think it would be easier for someone who reads the code.
And it will be more stable if we introduce new status in the futur (archived ...)
assouktim
force-pushed
the
fix/dercbot-1385
branch
from
5fa0dc0 to
722520c
Compare
scezen
approved these changes
Feb 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR ensure that the FAQ question tab only gets the sentences that were train for this FAQ and not all the sentences classified automatically for this FAQ.