Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cleanup of newman package #6

Merged
merged 6 commits into from
Sep 5, 2024
Merged

cleanup of newman package #6

merged 6 commits into from
Sep 5, 2024

Conversation

golanglemonade
Copy link
Member

@golanglemonade golanglemonade commented Sep 5, 2024

  • fixes buildkite pipeline
  • moves options and NewEmailMessageWithOptions to newman so it aligns with the other functions instead of being in shared
  • Updates all providers New* functions to return the newman.EmailSender interface, rather than the explicit type so everything conforms to the interface.
  • Adds a Send + SendWithContext so all providers have the same functions, aligns to the interface (in a few the context isn't used but would rather the interface is enforced and we can come back to ensuring it is used at a later time)
  • Removes the stutter from function names, e.g. instead of resend.NewResendEmailSender, it is now just resend.New or instead of resend.ResendOption, it is now resend.Option
  • Adds test for resend since this is our first-class provider
  • Updates postmark to use httpsling instead of creating a http.Client from scratch
  • Adds a mock provider and a WithDevMode option for the resend provider that will log emails to a directory instead of sending them when it is enabled

Signed-off-by: Sarah Funkhouser <[email protected]>
Signed-off-by: Sarah Funkhouser <[email protected]>
Signed-off-by: Sarah Funkhouser <[email protected]>
Signed-off-by: Sarah Funkhouser <[email protected]>
Signed-off-by: Sarah Funkhouser <[email protected]>
Copy link

sonarqubecloud bot commented Sep 5, 2024

@golanglemonade golanglemonade marked this pull request as ready for review September 5, 2024 18:21
@matoszz matoszz merged commit 5131a45 into main Sep 5, 2024
10 checks passed
@matoszz matoszz deleted the cleanup-and-such branch September 5, 2024 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants