refactor: tidy shoeReaderCount bool logic

theopensystemslab · Oct 9, 2024 · 507342e · 507342e
1 parent db2b0a6
commit 507342e
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/editor.planx.uk/src/ui/shared/CharacterCounter.tsx b/editor.planx.uk/src/ui/shared/CharacterCounter.tsx
@@ -29,7 +29,7 @@ export const CharacterCounter: React.FC<Props> = ({ limit, count }) => {
       setShowReaderCount(false);
     }
     updateCharacterCount(currentCharacterCount);
-  }, [currentCharacterCount, updateCharacterCount]);
+  }, [currentCharacterCount, updateCharacterCount, count, screenReaderCount]);
 
   const characterLimitText = showCharacterLimitError
     ? `You have ${Math.abs(currentCharacterCount)} characters too many`
@@ -59,7 +59,7 @@ export const CharacterCounter: React.FC<Props> = ({ limit, count }) => {
         {characterLimitText}
       </Typography>
       <Typography aria-live="polite" aria-atomic="true" sx={visuallyHidden}>
-        {showReaderCount ? screenReaderCountText : ""}
+        {showReaderCount && screenReaderCountText}
       </Typography>
     </>
   );