Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: upgrade Storybook to v7 #1908

Merged
merged 3 commits into from
Jul 4, 2023
Merged

Conversation

jessicamcinchak
Copy link
Member

@jessicamcinchak jessicamcinchak commented Jul 4, 2023

Followed instructions here https://storybook.js.org/docs/react/migration-guide#automatic-upgrade

I haven't started updating components yet, so some may still be broken. But this is a much fresher interface & feature set to start from 🎨

return config;
},
babel: async (options) => ({
babel: async options => ({
Copy link
Member Author

@jessicamcinchak jessicamcinchak Jul 4, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

normally, Storybook v7 would require our project to have a .babelrc file, but our combo here of @storybook/react-webpack5 framework with @storybook/preset-create-react-app addon fit into the "don't need to do anything" exception explained here: https://github.com/storybookjs/storybook/blob/next/MIGRATION.md#babel-mode-v7-exclusively

@jessicamcinchak
Copy link
Member Author

Update Storybook

@jessicamcinchak jessicamcinchak requested a review from a team July 4, 2023 17:08
@github-actions
Copy link

github-actions bot commented Jul 4, 2023

Removed vultr server and associated DNS entries

Copy link
Contributor

@DafyddLlyr DafyddLlyr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Totally worth taking the time right now to jump up a major version and fix things just once 💪

@jessicamcinchak jessicamcinchak merged commit 8b6762a into main Jul 4, 2023
10 checks passed
@jessicamcinchak jessicamcinchak deleted the jess/upgrade-storybook-v7 branch July 4, 2023 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants