feat: Boilerplate next steps component #1909
Conversation
|
Removed vultr server and associated DNS entries |
| @@ -46,6 +46,7 @@ const NodeTypeSelect: React.FC<{ | |||
| <optgroup label="Question"> | |||
| <option value={TYPES.Statement}>Question</option> | |||
| <option value={TYPES.Checklist}>Checklist</option> | |||
| {/* <option value={TYPES.NextSteps}>Next steps</option> */} | |||
There was a problem hiding this comment.
This grouping makes sense to me too ➕
As long as the Public display shows "Under development", I'd actually be in favor of this not being commented out in this list so we can easily test/preview on the pizza! And that should be enough of a signal to Editors to not use it yet
There was a problem hiding this comment.
Thanks, I've updated so this is unhidden, also updated the description with a pizza preview link for the component.
| @@ -29,4 +29,5 @@ export enum TYPES { | |||
| Send = 650, | |||
| Calculate = 700, | |||
| Confirmation = 725, | |||
| NextSteps = 730, | |||
There was a problem hiding this comment.
This works ➕ There's no obvious method here, but as long as it's a new unique number it'll be good to go!
One new thing the original docs don't cover I think is that this list of Component types is now also maintained in planx-core and will need to be updated here as well: https://github.com/theopensystemslab/planx-core/blob/main/src/types/component.ts
There was a problem hiding this comment.
Thanks, I've added as a new PR to planx-core:
theopensystemslab/planx-core#53
| function Component(props: Props) { | ||
| return ( | ||
| <Card handleSubmit={props.handleSubmit} isValid> | ||
| <QuestionHeader title={props.title} description={props.description} /> |
There was a problem hiding this comment.
A more flexible option is to use <QuestionHeader {...props} /> here which will then also automatically pick up help text if it's defined.
Otherwise, as-is:
- you'd define help text in the editor but it wouldn't be picked up in the Public preview
- you'll have to keep adding those prop fields manually like
howMeasured={props.howMeasured}and so on
PR adds the boilerplate setup for the Next Steps component, based on the work of Jess https://github.com/theopensystemslab/planx-new/pull/1448/files
Bits I'm not sure about:
Pizza preview here:
https://1909.planx.pizza/testing/next-steps-test/preview?analytics=false