Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Drop 'engines' from package.json #1918

Merged
merged 1 commit into from
Jul 6, 2023
Merged

chore: Drop 'engines' from package.json #1918

merged 1 commit into from
Jul 6, 2023

Conversation

DafyddLlyr
Copy link
Contributor

@DafyddLlyr DafyddLlyr commented Jul 6, 2023

Incremental change to get us closer to resolving #1911

I think it's wise to drop this for a few reasons -

  • It makes managing version numbers more work (especially compared with repository variables)
  • We're not really tied to a version number in a totally hard way (the repo will probably be fine on Node 17)
  • We already have .nvmrc in the project root which essentially handles this for us, and details in the readme of required versions
  • It's potentially causing issues when upgrading across repositories

@DafyddLlyr DafyddLlyr requested review from builditben and a team and removed request for builditben July 6, 2023 09:48
@github-actions
Copy link

github-actions bot commented Jul 6, 2023

Removed vultr server and associated DNS entries

Copy link
Member

@jessicamcinchak jessicamcinchak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks okay to me, seems to be working as expected !

@DafyddLlyr DafyddLlyr merged commit f714545 into main Jul 6, 2023
10 checks passed
@DafyddLlyr DafyddLlyr deleted the dp/drop-engines branch July 6, 2023 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants