Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: replacing fetchCurrentTeam with fetchCurrentTeamSettings in General Settings #3663

Merged
merged 3 commits into from
Sep 12, 2024

Conversation

RODO94
Copy link
Contributor

@RODO94 RODO94 commented Sep 12, 2024

Switching the query in General Settings index.tsx to pull only TeamSettings from a query from planx-core rather than all of the items from the teams table.

The paired planx-core change is here: theopensystemslab/planx-core#509

the planx-core references have been updated in line with the merged commit above.

Copy link

github-actions bot commented Sep 12, 2024

Removed vultr server and associated DNS entries

Copy link
Contributor

@DafyddLlyr DafyddLlyr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few tidy ups required here that have been missed. Solution works as expected though!

Copy link
Contributor

@DafyddLlyr DafyddLlyr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect! Thanks so much for the quick turnaround here @RODO94 🙌

@RODO94 RODO94 force-pushed the rory/team-settings-sub-email-fix branch from a009d67 to 00985c1 Compare September 12, 2024 15:13
@RODO94 RODO94 merged commit be56687 into main Sep 12, 2024
12 checks passed
@RODO94 RODO94 deleted the rory/team-settings-sub-email-fix branch September 12, 2024 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants