Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Improve logging on Notify errors #3665

Merged
merged 2 commits into from
Oct 1, 2024
Merged

Conversation

DafyddLlyr
Copy link
Contributor

@DafyddLlyr DafyddLlyr commented Sep 12, 2024

@DafyddLlyr DafyddLlyr changed the title chore: Improve logging on Notify errors [skip pizza] chore: Improve logging on Notify errors Sep 12, 2024
@DafyddLlyr DafyddLlyr requested a review from a team September 12, 2024 15:43
Copy link
Member

@jessicamcinchak jessicamcinchak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this, also noticed that confirmation template bug.

One small thought: it's been really handy to extract Hasura send event details out into the submissions log view to save paging through the event logs themselves - I wonder if it's worth doing the same for email events (just internal view, no reason to expose in editor yet)?

Copy link

github-actions bot commented Oct 1, 2024

Removed vultr server and associated DNS entries

@DafyddLlyr DafyddLlyr merged commit 469b115 into main Oct 1, 2024
12 checks passed
@DafyddLlyr DafyddLlyr deleted the dp/improve-notify-logging branch October 1, 2024 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants