feat: Remove Page workaround UI from List component #3680
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DafyddLlyr
commented
Sep 16, 2024
| </SelectInput> | ||
| </InputRowItem> | ||
| </InputRow> | ||
| <ErrorWrapper error={formik.errors.schema?.max}> |
There was a problem hiding this comment.
Big diff here - the only change is the addition of this ErrorWrapper.
DafyddLlyr
changed the title
|
Removed vultr server and associated DNS entries |
RODO94
reviewed
Sep 16, 2024
2 tasks
jamdelion
approved these changes
Sep 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
isPageComponentvariable from the List component, and the associated UI changesWhy?
This was always a bit of unintended workaround, and we're now explicitly removing this as a Page component is likely a more suitable option.
This PR won't break any existing flows or behaviours, it will simply stop pseudo-Page components from being generated. Once the feature flag is removed from the Page feature, we can migrate any flows using the AdvertConsent schema to be a Page, and remove this option from the List schema folder.