feat: Map and Label Happy Path Tests #3690
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Removed vultr server and associated DNS entries |
DafyddLlyr
approved these changes
Sep 17, 2024
There was a problem hiding this comment.
A few very small nit comments to take a look through here.
PR is great through - clean and easy to ready, love it 👍
On the handleSubmit() - it's worth explicitly testing that this has not been called when validation errors are shown. I'd suggest that rather than adding this to a random test or each test, just add a new test for just this instance - a little more atomic and explicit.
editor.planx.uk/src/@planx/components/MapAndLabel/Public/index.test.tsx
Outdated
Show resolved
Hide resolved
editor.planx.uk/src/@planx/components/MapAndLabel/Public/index.test.tsx
Outdated
Show resolved
Hide resolved
editor.planx.uk/src/@planx/components/MapAndLabel/test/utils.ts
Outdated
Show resolved
Hide resolved
editor.planx.uk/src/@planx/components/MapAndLabel/Public/index.test.tsx
Outdated
Show resolved
Hide resolved
DafyddLlyr
approved these changes
Sep 17, 2024
| @@ -186,6 +186,22 @@ describe("validation and error handling", () => { | |||
| }); | |||
| // shows the error state on a tab when it's invalid | |||
| }); | |||
|
|
|||
| it("does not trigger handleSubmit when errors exist", async () => { | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Running through the Happy Path test to-dos. Tried to do a nice amount of refactoring to keep the testing concise but explicit, so I have some simple functions handling "Clicking Continue" and "Checking for Error Messages are Populated or Empty" since these are repeatable situations without a high amount of meaning or context for the test.
I would be interested to know if I should be waiting for a
handleSubmit()to be called to confirm the happy path is successful rather than just checking the absence of error messages.