fix: Flow URLs should re-compute on re-render of Sidebar #3692
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DafyddLlyr
force-pushed
the
dp/fix-sidebar-url-updates
branch
from
099a5b1
to
07d3086
Compare
|
Removed vultr server and associated DNS entries |
RODO94
approved these changes
Sep 17, 2024
| @@ -147,7 +148,7 @@ export const PublishFlowButton = () => { | |||
| <Box pb={2}> | |||
| <Typography variant="body2"> | |||
| {`Preview these content changes in-service before publishing `} | |||
| <Link href={urls.preview} target="_blank"> | |||
| <Link href={previewURL} target="_blank"> | |||
There was a problem hiding this comment.
nit: should we be using rel="noopener" in combo with the target="_blank" - I've always done it for security reasons, but I don't know enough to determine whether it's actually useful in all scenarios
There was a problem hiding this comment.
Good spot! When linking internally this isn't required, but is best practice when using any third-party resources.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's the problem?
urlsoutside of the lifecycle scope of a component, this is never re-generatedWhat's the solution?
Sidebarcomponent