refactor: Simplify and improve description radio layout #3729
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Removed vultr server and associated DNS entries |
jamdelion
approved these changes
Sep 24, 2024
DafyddLlyr
approved these changes
Sep 24, 2024
| sx={(theme) => ({ | ||
| mb: variant === "default" ? 1 : 0, | ||
| alignItems: "flex-start", | ||
| ".MuiFormControlLabel-label": { |
There was a problem hiding this comment.
We can also use import { formLabelClasses } from "@mui/material/FormControlLabel" to get this in a more reliable way.
Suggested change
| ".MuiFormControlLabel-label": { | |
| [`& .${formControlLabelClasses.label}`]: { |
There was a problem hiding this comment.
Thanks for this @DafyddLlyr , updated.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
An overdue change — simplifies questions/radios so that they are no longer placed in a 3 column-grid with border when a description is present. Follows the GOV.UK pattern: https://design-system.service.gov.uk/components/radios/#radio-items-with-hints
Image radios are still gridded for now (to be explored as a further design challenge as we are not following a GOV.UK content pattern).
Preview:
https://3729.planx.pizza/testing/question-layouts/preview
Before:
After:
