chore: Replace jest linting with vitest linting #3735
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DafyddLlyr
commented
Sep 27, 2024
There was a problem hiding this comment.
Heavy use of helper functions in this file which wrap expect() functions, so eslint-disable-next-line @vitest/expect-expect is needed throughout. Adding this once to the whole file, instead of for each test, seemed like a riskier approach.
|
Removed vultr server and associated DNS entries |
jessicamcinchak
approved these changes
Sep 30, 2024
DafyddLlyr
force-pushed
the
dp/linting-jest-errors
branch
from
d771e16
to
171a0fd
Compare
DafyddLlyr
force-pushed
the
dp/linting-jest-errors
branch
from
171a0fd
to
4b39be5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
pnpm lint:errorscript which just identifies errors, ignoring warningsI think that #3731 introduced this issue which dropped jest as a peer dependency.