feat(search): Add word break after special characters in search cards #3741
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DafyddLlyr
changed the title
|
Removed vultr server and associated DNS entries |
jessicamcinchak
approved these changes
Oct 1, 2024
| {char} | ||
| </Typography> | ||
| {/* Add wordbreak after special characters */} | ||
| {char.match(/\W/) && <wbr />} |
There was a problem hiding this comment.
I don't fully understand why this is outside of the <Typography> block and only within the fragment? Don't we want all characters to share the styles above (eg indexed/matching characters after a special character should still have bold highlighting?)
There was a problem hiding this comment.
Good question! This is a little unexpected as the headline breaks each word into characters and inserts a "word" break after them. The <wbr/> is just a non-visual element so that it splits in the right place.
The reason there's only one word highlighted is that the search is configured to just return the first match from a string, not all.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds a
<wbr/>element (docs) after a headline character if it's a special character.Why?
The headline element is split into a series of spans (one per character), so applying a regular word break css rule to the parent won't work. By inserting a
<wbr/>each time we hit a non-alphanumeric character, we allow the browser to break where it sees fit.