Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: clear MapAndLabel breadcrumbs if FindProperty address has changed #3751

Merged
merged 1 commit into from
Oct 2, 2024

Conversation

jessicamcinchak
Copy link
Member

@jessicamcinchak jessicamcinchak commented Oct 2, 2024

Fixes a buggy observation in user testing ! When navigating "back" or "changing" a MapAndLabel component, we only want to retain your previous answer if FindProperty has not also changed because MapAndLabel relies on the geographic position of the site address.

New behavior:

  • If you change your site address, you should now also be re-prompted to fill out MapAndLabel fresh (similar to DrawBoundary, PlanningConstraints, etc), without any previous answers retained
  • If you're coming "back" to MapAndLabel without changing your site address, your answers should still be retained

@jessicamcinchak jessicamcinchak requested a review from a team October 2, 2024 09:16
@jessicamcinchak jessicamcinchak marked this pull request as ready for review October 2, 2024 09:16
Copy link

github-actions bot commented Oct 2, 2024

Removed vultr server and associated DNS entries

@jessicamcinchak jessicamcinchak changed the title fix: clear MapAndLabel breadcrumbs if FindProperty or DrawBoundary have changed fix: clear MapAndLabel breadcrumbs if FindProperty address has changed Oct 2, 2024
Copy link
Contributor

@RODO94 RODO94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: I had an issue in a weird edge case where if you don't actually change the address after clicking to change it, and move to the next tab, the data is maintained but the tab isn't selected.

Screenshot 2024-10-02 at 15 57 04

Don't expect it to happen, and my instinct was to click next or click on the tab which resolved it, just initially confusing

@jessicamcinchak
Copy link
Member Author

@RODO94 thanks for reviewing & description of this edge casey bug - think minimised tab should be addressed by #3753 ! Will get this merged to main alongside other fixes, then see if still recreatable 👍

@jessicamcinchak jessicamcinchak merged commit 699c784 into main Oct 2, 2024
12 checks passed
@jessicamcinchak jessicamcinchak deleted the jess/map-and-label-back-behavior branch October 2, 2024 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants