Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: Make SelectMultiple component independent of FileUploadAndLabel #3760

Merged
merged 2 commits into from
Oct 4, 2024
Merged

refactor: Make SelectMultiple component independent of FileUploadAndLabel #3760

merged 2 commits into from
Oct 4, 2024

Conversation

DafyddLlyr
Copy link
Contributor

@DafyddLlyr DafyddLlyr commented Oct 4, 2024 •
edited
Loading

What does this PR do?

  • Make a new SelectMultiple component
  • Make a SelectMultipleFileTypes component
  • Just a refactor, no new functionality or changes, and the existing FileUploadAndLabel components all have a decent level of test coverage

Why?

  • Hit this as a requirement for tagging nodes, based on @ianjon3s's work here - wip: Placement and styling of tags #3754
  • It makes more sense to share how we use a multiple select than to repeat a load of code
  • As this relies on the prop multiple being present, there's no simple way of handling this via a MUI variant

@DafyddLlyr DafyddLlyr changed the title dp/select multiple refactor: Make SelectMultiple component independent of FileUploadAndLabel Oct 4, 2024
@DafyddLlyr DafyddLlyr requested a review from a team October 4, 2024 08:03
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 4, 2024 •
edited
Loading

Removed vultr server and associated DNS entries

jessicamcinchak
jessicamcinchak approved these changes Oct 4, 2024
View reviewed changes
Copy link
Member

@jessicamcinchak jessicamcinchak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Smart !

@DafyddLlyr DafyddLlyr merged commit 934b242 into main Oct 4, 2024
12 checks passed
@DafyddLlyr DafyddLlyr deleted the dp/select-multiple branch October 4, 2024 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jessicamcinchak jessicamcinchak jessicamcinchak approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DafyddLlyr @jessicamcinchak