feat: Use zustand middleware to persist to local storage #3767
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Removed vultr server and associated DNS entries |
DafyddLlyr
commented
Oct 7, 2024
Comment on lines
+155
to
+162
| <Collapse | ||
| in={showSidebar} | ||
| orientation="horizontal" | ||
| collapsedSize={SIDEBAR_WIDTH_MINIMISED} | ||
| sx={{ height: "100%" }} | ||
| easing={"ease-in-out"} | ||
| timeout={200} | ||
| > |
There was a problem hiding this comment.
Diff here is a bit weird - I've just wrapped this component in a MUI Collapse (docs) instead of controlling this via variables passed to a styled component.
RODO94
approved these changes
Oct 7, 2024
| ]); | ||
|
|
||
| const [activeTab, setActiveTab] = useState<SidebarTabs>("PreviewBrowser"); | ||
| const [isSidebarMinimised, setIsSidebarMinimised] = useState<boolean>(() => { | ||
| const savedState = localStorage.getItem("isSidebarMinimised"); |
There was a problem hiding this comment.
@DafyddLlyr is the gain that we swap this for the code above it:
const [resetPreview, isFlowPublished, toggleSidebar, showSidebar] = useStore((state) => [
state.resetPreview,
state.isFlowPublished,
state.toggleSidebar,
state.showSidebar,
]);There was a problem hiding this comment.
Yep, we also remove the togglePreview() function below as it's now handled by Zustand.
| hideTestEnvBanner: () => set({ isTestEnvBannerVisible: false }), | ||
| }), | ||
| { | ||
| name: "editorUIStore", |
There was a problem hiding this comment.
Is Local Storage the default here or have I missed where you specified this?
There was a problem hiding this comment.
That's correct, local storage is just default so we don't need to specify anything here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a rethink of two Friday quick fixes -
isMinimisedprop #3765togglePreview()method from store #3766Originally, I was just resolving a React error and then tidying up some unused store variables.
In this approach, I'm using Zustand's persist middleware pattern (docs) to handle the variable stores in local storage. Here's the benefits to this approach as I see them -
shouldForwardPropetc)