chore: Fix React :nth-child warnings
#3768
Conversation
| // Styles for placeholder text, to match ui/Input.tsx | ||
| "& p.is-editor-empty:nth-child(1)::before": { | ||
| color: theme.palette.text.placeholder, | ||
| opacity: 1, | ||
| content: `attr(data-placeholder)`, | ||
| float: "left", | ||
| height: 0, | ||
| pointerEvents: "none", | ||
| }, |
There was a problem hiding this comment.
Removed as there's no reference to the class is-editor-empty elsewhere in the codebase, I believe this is redundant.
There was a problem hiding this comment.
@DafyddLlyr I see that there's no longer placeholder text on the Editor Model:
Wonder if this is linked to this change being removed?
There was a problem hiding this comment.
Aha - I missed this somehow - taking a look thanks!
| "&:not(:nth-child(1))": { | ||
| paddingLeft: theme.spacing(2), | ||
| }, |
There was a problem hiding this comment.
I can't see where the style applies, tried all usual tricks of solid red borders, hotpink background etc to locate when this should apply without any luck.
|
Removed vultr server and associated DNS entries |
There was a problem hiding this comment.
Thanks for picking this up! Absolute dream.
@DafyddLlyr one question still sitting there regarding placeholder text
| // Styles for placeholder text, to match ui/Input.tsx | ||
| "& p.is-editor-empty:nth-child(1)::before": { | ||
| color: theme.palette.text.placeholder, | ||
| opacity: 1, | ||
| content: `attr(data-placeholder)`, | ||
| float: "left", | ||
| height: 0, | ||
| pointerEvents: "none", | ||
| }, |
There was a problem hiding this comment.
@DafyddLlyr I see that there's no longer placeholder text on the Editor Model:
Wonder if this is linked to this change being removed?
DafyddLlyr
force-pushed
the
dp/fix-nth-child-warning
branch
from
8959ef3
to
aac6924
Compare
| @@ -97,7 +97,8 @@ export const RichContentContainer = styled(Box)(({ theme }) => ({ | |||
| }, | |||
| }, | |||
| // Styles for placeholder text, to match ui/Input.tsx | |||
| "& p.is-editor-empty:nth-child(1)::before": { | |||
| // "& p.is-editor-empty:nth-child(1)::before": { | |||
There was a problem hiding this comment.
Hahah sorry - very good catch thank you 😅
Fixed in a0b896b
This reverts commit 3262ef8.
Been meaning to get around to this one for a while!