fix: Restore loading bar and FlowEditor state on Editor-only routes
#3772
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DafyddLlyr
changed the title
FlowEditor state on Editor-only routes
|
Removed vultr server and associated DNS entries |
DafyddLlyr
force-pushed
the
dp/fix-route-loading
branch
from
4916fd4
to
7b9d382
Compare
jamdelion
reviewed
Oct 8, 2024
| ) | ||
| : compose( | ||
| withView(loadingView), | ||
| const loadDraftRoutes = () => |
There was a problem hiding this comment.
Nice refactor - much easier to read :)
jamdelion
approved these changes
Oct 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
FlowEditorstate on route changes #3671 and fix: Add loading indicator to public pages #3714"*": editorRoutesin theloadingViewin order to restore the loading spinner to public facing pages, here I'm (finally!) fixing this properly.How can I test this?