feat: Setup additional node tags #3775
Conversation
|
Removed vultr server and associated DNS entries |
DafyddLlyr
force-pushed
the
dp/additional-tags
branch
from
46465d0
to
3a41393
Compare
| import React from "react"; | ||
| import { FONT_WEIGHT_SEMI_BOLD } from "theme"; | ||
|
|
||
| const TooltipWrap = styled(({ className, ...props }: TooltipProps) => ( |
There was a problem hiding this comment.
This is repeated a few places now, I'll open up a follow up PR to make a variant or standardise this via the theme.
| : theme.palette.text.disabled, | ||
| })} | ||
| > | ||
| {showTags ? <LabelIcon /> : <LabelOffIcon />} |
There was a problem hiding this comment.
This pattern may be restricting us more than we need to by limiting us to using "off" MUI icons if we want to expand this to toggle images or data fields?
| import React from "react"; | ||
| import { getContrastTextColor } from "styleUtils"; | ||
| import { FONT_WEIGHT_SEMI_BOLD } from "theme"; | ||
|
|
||
| export const TAG_DISPLAY_VALUES: Record< |
There was a problem hiding this comment.
Not sure if I have the right colour scheme or setup here @ianjon3s , should be be a quick and easy fix though!
| const showTags = useStore((state) => state.showTags); | ||
| if (!showTags) return null; | ||
|
|
||
| const tagBgColor = theme.palette.nodeTag[TAG_DISPLAY_VALUES[tag].color]; |
There was a problem hiding this comment.
Glad you've extracted this out but it's still quite horrible how nested it is 😂
| > = { | ||
| placeholder: { | ||
| color: "#FAE1B7", |
There was a problem hiding this comment.
Very much approve of the removal of colour hex codes 😁
What does this PR do?
main)Screen.Recording.2024-10-08.at.13.42.49.mov