Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Center align text env banner vertically #3777

Merged
merged 1 commit into from
Oct 8, 2024
Merged

fix: Center align text env banner vertically #3777

merged 1 commit into from
Oct 8, 2024

Conversation

DafyddLlyr
Copy link
Contributor

@DafyddLlyr DafyddLlyr commented Oct 8, 2024 •
edited
Loading

What does this PR do?

  • Ensures that the content of the test environment banner are vertically aligned correctly
  • It's always been off as alignItems: "center" was used without display: "flex", it's just more noticeable now following fix: Remove additional Editor scroll #3734 which made the banner taller
Before After
image image

@DafyddLlyr DafyddLlyr requested a review from a team October 8, 2024 12:22
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 8, 2024 •
edited
Loading

Removed vultr server and associated DNS entries

ianjon3s
ianjon3s approved these changes Oct 8, 2024
View reviewed changes
Copy link
Contributor

@ianjon3s ianjon3s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good spot!

@DafyddLlyr DafyddLlyr merged commit b912929 into main Oct 8, 2024
12 checks passed
@DafyddLlyr DafyddLlyr deleted the dp/center-align-test-env-banner branch October 8, 2024 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ianjon3s ianjon3s ianjon3s approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DafyddLlyr @ianjon3s