Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Add permission guard to "Add a new Editor" button #3786

Merged
merged 2 commits into from
Oct 10, 2024
+14 −12
Merged

fix: Add permission guard to "Add a new Editor" button #3786

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cb5433e
test: Make test fail by setting non-templates team
DafyddLlyr Oct 9, 2024
354b830
fix: Make test pass by padding permission guard
DafyddLlyr Oct 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 13 additions & 11 deletions editor.planx.uk/src/pages/FlowEditor/components/Team/components/MembersTable.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -194,17 +194,19 @@ export const MembersTable = ({
</StyledTableRow>
))}
{showAddMemberButton && (
<TableRow>
<TableCell colSpan={5}>
<AddButton
onClick={() => {
addUser();
}}
>
Add a new editor
</AddButton>
</TableCell>
</TableRow>
<Permission.IsPlatformAdmin>
<TableRow>
<TableCell colSpan={5}>
<AddButton
onClick={() => {
addUser();
}}
>
Add a new editor
</AddButton>
</TableCell>
</TableRow>
</Permission.IsPlatformAdmin>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We must have had a bad rebase somewhere because I swear I made this exact change a couple weeks ago ?? 👀

Eg https://github.com/theopensystemslab/planx-new/pull/3713/files#diff-b5928b9d92361e26a33f6c0b9af0253b319eab4128cee43689cce0eb88cc87c5R151

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah I thought the exact same thing! I swear we talked about this and fixed it before as well but couldn't find the PR.

Rebase makes sense as the cause of this regression 👍

)}
</TableBody>
</Table>
Expand Down
2 changes: 1 addition & 1 deletion editor.planx.uk/src/pages/FlowEditor/components/Team/tests/TeamMembers.addNewEditor.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,7 +129,7 @@ describe("when a user is not a platform admin", () => {
useStore.setState({
teamMembers: mockTeamMembersData,
user: mockPlainUser,
teamSlug: "templates",
teamSlug: "trumptonshire",
});
});

Expand Down
Loading