Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: Result component multiline inputs #3796

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

refactor: Result component multiline inputs #3796

wants to merge 2 commits into from
+15 −22

Conversation

ianjon3s
Copy link
Contributor

@ianjon3s ianjon3s commented Oct 10, 2024 •
edited
Loading

What does this PR do?

  • Updates result component flag descriptions to be multiline text inputs
  • Adjusts layout to vertical
  • Adds input labels in place of input placeholders
  • Removes accordion functionality in favour of presenting a form-based interface

Example empty form:
https://3796.planx.pizza/testing/result-empty/nodes/_root/nodes/twngigiPHD/edit

Example populated form:
https://3796.planx.pizza/buckinghamshire/find-out-if-you-need-planning-permission/nodes/AVaOWQEwBD/nodes/yc1uC0Mwc7/edit

Previous:
image

Updated:
image

@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 10, 2024 •
edited
Loading

Pizza

Deployed ba08002 to https://3796.planx.pizza.

Useful links:

@ianjon3s ianjon3s marked this pull request as ready for review October 10, 2024 12:18
@ianjon3s
Copy link
Contributor Author

Make text boxes in 'Results' component properly visible so they are easier to edit

@ianjon3s ianjon3s requested a review from a team October 10, 2024 12:21
DafyddLlyr
DafyddLlyr approved these changes Oct 10, 2024
View reviewed changes
Copy link
Contributor

@DafyddLlyr DafyddLlyr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! 👍

One small suggestion would be to remove the asterix's from the labels. I believe they were previously in place to indicate if a section was populated or not, but this is no longer relevant now that the inputs are visible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DafyddLlyr DafyddLlyr DafyddLlyr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ianjon3s @DafyddLlyr