Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace developmentAllowRuntimeRestart flag #349

Merged
merged 1 commit into from
Dec 6, 2023
Merged

Replace developmentAllowRuntimeRestart flag #349

merged 1 commit into from
Dec 6, 2023

Conversation

RDIL
Copy link
Member

@RDIL RDIL commented Nov 28, 2023

Applies the resolution we discussed. Fixes #310

@RDIL RDIL added the security This is a security problem or fix. label Nov 28, 2023
@RDIL RDIL requested a review from LennardF1989 November 28, 2023 17:05
github-advanced-security[bot]
github-advanced-security bot found potential problems Nov 28, 2023
View reviewed changes
components/oauthToken.ts
? "secret"
: randomBytes(32).toString("hex")
export const JWT_SECRET = PEACOCK_DEV
? "secret"

Check failure

Code scanning / CodeQL

Hard-coded credentials

The hard-coded value "secret" is used as [key](1). The hard-coded value "secret" is used as [key](2). The hard-coded value "secret" is used as [key](3).
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lmao

AnthonyFuller
AnthonyFuller approved these changes Nov 28, 2023
View reviewed changes
Copy link
Contributor

@AnthonyFuller AnthonyFuller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am utterly convinced I did this.

@RDIL RDIL changed the title Always use consistent JWT secret in dev Replace developmentAllowRuntimeRestart flag Dec 6, 2023
@RDIL RDIL merged commit 589ba85 into v7 Dec 6, 2023
@RDIL RDIL deleted the rdil/runtime-restart branch December 6, 2023 04:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AnthonyFuller AnthonyFuller AnthonyFuller approved these changes

@LennardF1989 LennardF1989 Awaiting requested review from LennardF1989

Assignees
No one assigned
Labels
security This is a security problem or fix.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove hard-coded credentials
2 participants
@RDIL @AnthonyFuller