Make same path copy/move a no-op for AWS S3

thephpleague · Aug 17, 2024 · c6ff6d4 · c6ff6d4
1 parent ea23280
commit c6ff6d4
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 1 deletion.
diff --git a/AwsS3V3Adapter.php b/AwsS3V3Adapter.php
@@ -407,6 +407,10 @@ private function retrievePaginatedListing(array $options): Generator
 
     public function move(string $source, string $destination, Config $config): void
     {
+        if ($source === $destination) {
+            return;
+        }
+
         try {
             $this->copy($source, $destination, $config);
             $this->delete($source);
@@ -417,6 +421,10 @@ public function move(string $source, string $destination, Config $config): void
 
     public function copy(string $source, string $destination, Config $config): void
     {
+        if ($source === $destination) {
+            return;
+        }
+
         try {
             $visibility = $config->get(Config::OPTION_VISIBILITY);
 

diff --git a/AwsS3V3AdapterTest.php b/AwsS3V3AdapterTest.php
@@ -81,7 +81,7 @@ protected function tearDown(): void
 
     protected function setUp(): void
     {
-        if (PHP_VERSION_ID < 801000) {
+        if (PHP_VERSION_ID < 80100) {
             $this->markTestSkipped('AWS does not support this anymore.');
         }