Issue #323 dynamic property assignment #326
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… make concrete with a register method.
…nterface because of the Func class.
…al Template property in classes that implement the Extension interface.
|
Hey, thanks for this submission, but I'm going to close it in favor of #329 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This Pull Request will address the deprecation of dynamically adding properties to objects, as outlined in this issue. From the Author's suggestion, I have chosen to break the API and add the
setTemplate()method into the Interface.This change will pass all tests and has updated documentation. This will break older versions of the library that rely on the
$templateproperty to be public (or non-existent). I am open to looking to a better way to compose the necessity of having theTemplateclass injected into theFuncclass that further injects into theExtensionInterfaceconcrete classes.