Typecheck - Allow fn to any sized pointer cast

thepowersgang · Jan 29, 2024 · 4b818fb · 4b818fb
1 parent bcf9bd2
commit 4b818fb
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 3 deletions.
diff --git a/src/hir_typeck/expr_check.cpp b/src/hir_typeck/expr_check.cpp
@@ -394,7 +394,12 @@ namespace {
                     //}
                     }
                 TU_ARMA(Function, se) {
-                    if( de.inner != ::HIR::TypeRef::new_unit() && de.inner != ::HIR::CoreType::U8 && de.inner != ::HIR::CoreType::I8 ) {
+                    if( de.inner == ::HIR::TypeRef::new_unit() || de.inner == ::HIR::CoreType::U8 || de.inner == ::HIR::CoreType::I8 ) {
+                    }
+                    else if( m_resolve.type_is_sized(sp, de.inner) ) {
+                        // Allow it.
+                    }
+                    else {
                         ERROR(sp, E0000, "Invalid cast to " << dst_ty << " from " << src_ty);
                     }
                     }

diff --git a/src/hir_typeck/expr_cs.cpp b/src/hir_typeck/expr_cs.cpp
@@ -267,7 +267,9 @@ namespace {
                         // Keep around.
                     }
                     else {
-                        ERROR(sp, E0000, "Invalid cast to " << this->context.m_ivars.fmt_type(tgt_ty) << " from " << src_ty);
+                        //ERROR(sp, E0000, "Invalid cast to " << this->context.m_ivars.fmt_type(tgt_ty) << " from " << src_ty);
+                        // TODO: Only allow thin pointers? `c_void` is used in 1.74 libstd
+                        this->m_completed = true;
                     }
                     }
                 TU_ARMA(Primitive, s_e) {

diff --git a/src/mir/from_hir.cpp b/src/mir/from_hir.cpp
@@ -1436,7 +1436,7 @@ namespace {
                 }
                 else if( /*const auto* se =*/ ty_in.data().opt_Function() )
                 {
-                    if( de.inner != ::HIR::TypeRef::new_unit() && de.inner != ::HIR::CoreType::U8 && de.inner != ::HIR::CoreType::I8 ) {
+                    if( !m_builder.resolve().type_is_sized(node.span(), de.inner) ) {
                         BUG(node.span(), "Cannot cast to " << ty_out << " from " << ty_in);
                     }
                     // Valid