HomePage and Auth Page refactored #52
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
therealansh
requested changes
Jun 10, 2021
| @@ -0,0 +1,39 @@ | |||
| import 'package:flutter/material.dart'; | |||
| InputDecoration inputDecor({String hint, IconData prefix, bool obscure, IconData suffix, Function toogle}) { | |||
There was a problem hiding this comment.
This does not need to be refactored
There was a problem hiding this comment.
I changed some functionality of it too as it was using two bools before and doing an and operation on them now it only takes one and removed setState from it.
| onWillPop: () { | ||
| return onBackPressed(context); | ||
| }, | ||
| child: MaterialApp( |
There was a problem hiding this comment.
Dont take out another root of the remove this. And what does this widget do?
There was a problem hiding this comment.
When back button is pressed it opens Pop Button asking whether you want to quit or not.
There was a problem hiding this comment.
When back button is pressed it opens Pop Button asking whether you want to quit or not.
Yes i know but where are we using it?
|
And color constants refactoring isnt done yet |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.