Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support ape >=0.8.x #1

Merged
merged 4 commits into from
Jun 20, 2024
Merged

feat: support ape >=0.8.x #1

merged 4 commits into from
Jun 20, 2024

Conversation

Barabazs
Copy link

@Barabazs Barabazs commented Jun 20, 2024

This PR loosens the eth-ape version restriction so we can use ape-scroll with the latest versions.

This PR updates the plugin to be compatible with ape v0.8.x
Notable changes:

  • replaced incompatible ape_geth with ape_node in __init__.py
  • dropped support for python 3.8

Copy link

sourcery-ai bot commented Jun 20, 2024

Reviewer's Guide by Sourcery

This pull request loosens the version restriction for the eth-ape dependency in the setup.py file, allowing compatibility with versions up to but not including 1.0.0.


Tips
  • Trigger a new Sourcery review by commenting @sourcery-ai review on the pull request.
  • You can change your review settings at any time by accessing your dashboard:
    • Enable or disable the Sourcery-generated pull request summary or reviewer's guide;
    • Change the review language;
  • You can always contact us if you have any questions or feedback.

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @Barabazs - I've reviewed your changes and they look great!

Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.

@Barabazs Barabazs changed the title chore: loosen eth-ape version restriction feat: support ape >=0.8.x Jun 20, 2024
@theref theref merged commit 8fe518a into theref:main Jun 20, 2024
0 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants