Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update CI script python versions #2

Merged
merged 1 commit into from
Jun 21, 2024
Merged

fix: update CI script python versions #2

merged 1 commit into from
Jun 21, 2024

Conversation

Barabazs
Copy link

@Barabazs Barabazs commented Jun 20, 2024

This PR updates the used python versions in .pre-commit-config.yaml and .github/workflows/test.yaml. I have tested the changes on my fork and all checks are green 💚 : https://github.com/Barabazs/ape-scroll/actions/runs/9600206224

Summary by Sourcery

This pull request updates the Python versions used in the CI workflow and pre-commit configuration. The GitHub Actions workflow now uses Python 3.9 and includes additional versions in the testing matrix. The pre-commit configuration has also been updated to use Python 3.9.

  • Build:
    • Updated the default Python version in the pre-commit configuration to use Python 3.9 instead of 3.8.
  • CI:
    • Updated the Python version in the GitHub Actions workflow configuration to use Python 3.9 instead of 3.8.
    • Expanded the matrix of Python versions in the GitHub Actions workflow to include Python 3.9, 3.10, 3.11, and 3.12.

Copy link

sourcery-ai bot commented Jun 20, 2024

Reviewer's Guide by Sourcery

This pull request updates the Python versions used in the CI configuration and pre-commit hooks. Specifically, it changes the Python version from 3.8 to 3.9 in both .github/workflows/test.yaml and .pre-commit-config.yaml. Additionally, it updates the matrix strategy in the CI configuration to include Python versions 3.9, 3.10, 3.11, and 3.12, removing version 3.8.

File-Level Changes

Files Changes
.github/workflows/test.yaml
.pre-commit-config.yaml
Updated the Python versions used in CI and pre-commit configurations to newer versions.

Tips
  • Trigger a new Sourcery review by commenting @sourcery-ai review on the pull request.
  • You can change your review settings at any time by accessing your dashboard:
    • Enable or disable the Sourcery-generated pull request summary or reviewer's guide;
    • Change the review language;
  • You can always contact us if you have any questions or feedback.

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @Barabazs - I've reviewed your changes and they look great!

Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.

@theref theref merged commit 1b554fd into theref:main Jun 21, 2024
10 checks passed
@Barabazs Barabazs deleted the fix/CI branch June 21, 2024 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants