Refactor config loading #185
Conversation
- improve DRY - alter logging - allow extensibility - add foundation for environment variables as config
- improve DRY
|
Good concept. However, I'd like a merge function in Also, please run |
- remove deepmerge dependency - fix ruff formatting
|
I have added the internal implementation as requested |
The config categories can have defined separation, but preserve the dynamic nature of adding new config options by making all the internal class vars as dictionaries. This was necessary since storing global callbacks stored a state of the previous global_config var that wasn't populated. Signed-off-by: kingbri <[email protected]>
|
This PR wasn't working when testing, but the concept was good. So, I decided to migrate the global config module into a shared class instance instead. This should preserve the flexibility of adding more config options while using class based references in other modules. @SecretiveShell please take a look and I'll merge this in. |
- move to a complet class singleton to avoid propagation errors - remove legacy load confing precedure
Rename some methods and change comments. Signed-off-by: kingbri <[email protected]>
Why should this feature be added?
This PR refactors the way config files are loaded into tabbyAPI
It refactors the current functions to return a dictionary, reducing the use of the global variables.
A new load function is added to aggregate all the possible load config functions into a list of dictionaries
The global config is constructed by performing a deep merge on all the resulting configurations in the order they are listed
The individual functions to get the configuration are refactored to use a single factory, with nested functions using nested calls
Examples
This makes adding new sources of configuration much easier
The order of which configuration takes precedence when multiple competing settings are present is now much more obvious