Model: Fix inline loading and draft key #225
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a lack of foresight between the new config.yml and how it was structured. The "draft" key became "draft_model" without updating both the API request and inline loading keys. For the API requests, still support "draft" as legacy, but the "draft_model" key is preferred. Signed-off-by: kingbri <[email protected]>
Was not pushed before and caused errors of the kwargs being None. Signed-off-by: kingbri <[email protected]>
Draft model args weren't applying since there was a reset due to how the old override behavior worked. Signed-off-by: kingbri <[email protected]>
Use embedding_model_name to be inline with the config. Signed-off-by: kingbri <[email protected]>
Alias name to draft_model_name. Signed-off-by: kingbri <[email protected]>
Add prompt_template_name to be more descriptive. Signed-off-by: kingbri <[email protected]>
Alias name to model_name for config parity. Signed-off-by: kingbri <[email protected]>
Signed-off-by: kingbri <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bypasses template:
Fix inline load with draft models and rename the provided key internally to be consistent.