Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix draft model non-FA2 fallback #244

Merged
merged 1 commit into from
Nov 17, 2024

Conversation

DocShotgun
Copy link
Member

Is your pull request related to a problem? Please describe.
Fixes #238

Why should this feature be added?
N/A

Examples
N/A

Additional context
Flash attention was not being disabled for the draft model after being determined to be unavailable/incompatible.

@DocShotgun DocShotgun marked this pull request as ready for review November 16, 2024 05:31
@matatonic
Copy link

Confirmed, this fixes #238

@bdashore3 bdashore3 merged commit dfc8899 into theroyallab:main Nov 17, 2024
1 check passed
@DocShotgun DocShotgun deleted the draft-flash-attn-fix branch November 19, 2024 21:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Compatibility mode (CUDA < 8.0) not working with draft models
3 participants