Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Robust request length checking in generator #264

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
46 changes: 40 additions & 6 deletions backends/exllamav2/model.py
Original file line number Diff line number Diff line change
Expand Up @@ -1301,17 +1301,51 @@ async def generate_gen(

# The first index will always be the positive prompt
context_len = input_ids[0].size(dim=-1)
if context_len > self.config.max_seq_len:
raise ValueError(
f"Context length {context_len} is greater than max_seq_len "
f"{self.config.max_seq_len}"
)

# The second index will be the negative prompt if CFG is enabled
if negative_prompt is not None:
negative_context_len = input_ids[1].size(dim=-1)
else:
negative_context_len = 0

# Automatically set max_tokens to fill up the context
# This should be an OK default, but may be changed in the future
max_tokens = unwrap(
kwargs.get("max_tokens"), self.config.max_seq_len - context_len
kwargs.get("max_tokens"),
self.config.max_seq_len - max(context_len, negative_context_len),
)
if max_tokens < 1:
logger.warning("max_tokens must be a positive integer, setting to 1.")
max_tokens = 1

# Check total length of request
if context_len + max_tokens > self.config.max_seq_len:
raise ValueError(
f"Request length {context_len} + {max_tokens} is greater than "
f"max_seq_len {self.config.max_seq_len}"
)

# Check total length of negative prompt request if CFG is enabled
if negative_prompt is not None:
if context_len + max_tokens > self.config.max_seq_len:
raise ValueError(
f"Request length for negative prompt "
f"{negative_context_len} + {max_tokens} is greater than "
f"max_seq_len {self.config.max_seq_len}"
)
# Check total required pages for CFG request
if (
sum(
256 * math.ceil((context + max_tokens) / 256)
for context in (context_len, negative_context_len)
)
> self.cache_size
):
raise ValueError(
f"Total required page size for request "
f"{context_len} + {negative_context_len} + {max_tokens} * 2 "
f"is greater than cache_size {self.cache_size}"
)

# Set min_tokens to generate while keeping EOS banned
min_tokens = unwrap(kwargs.get("min_tokens"), 0)
Expand Down
Loading