Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Un-scuffed the Dockerfile #43

Closed
wants to merge 1 commit into from
Closed

Un-scuffed the Dockerfile #43

wants to merge 1 commit into from

Conversation

city-unit
Copy link
Contributor

@city-unit city-unit commented Dec 28, 2023 •
edited
Loading

Put the build order in... order so it actually can have good layers and whatnot. Remove useless env, don't copy config in either; that should just be defined in your compose file if you care I think.

@bdashore3 bdashore3 changed the base branch from main to dockerfile-rewrite December 28, 2023 05:43
bdashore3 pushed a commit that referenced this pull request Dec 28, 2023
@city-unit @bdashore3
Update Docker
e70729b 
Squash commit that merges #43, #44, and #45

Create .dockerignore

Make compose marginally better

Un-scuffed the Dockerfile
@bdashore3 bdashore3 deleted the branch theroyallab:dockerfile-rewrite December 28, 2023 23:27
@bdashore3 bdashore3 closed this Dec 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@city-unit @bdashore3