feat: bundle as AssetClass #1497
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mvanmeerbeck
previously requested changes
May 27, 2024
atkinsonholly
force-pushed
the
feat/marketplace-bundle-type
branch
from
725d9d6
to
704f681
Compare
atkinsonholly
commented
Jun 25, 2024
| /// @param newLandContractAddress Address of new LAND contract | ||
| function _setLandContract(ILandToken newLandContractAddress) internal { | ||
| // TODO: uncomment when ILandToken is supported by LandBase | ||
| // require(ERC165Checker.supportsInterface(address(newLandContractAddress, type(ILandToken).interfaceId), "invalid LAND address"); |
There was a problem hiding this comment.
TODO when packages/land is updated
There was a problem hiding this comment.
@atkinsonholly Do you remember what is supposed to be updated in packages/land?
atkinsonholly
commented
Jun 25, 2024
atkinsonholly
commented
Jun 25, 2024
atkinsonholly
commented
Jun 25, 2024
| 'setOrderValidatorContract', | ||
| // TODO: new tests for setRoyaltiesRegistry and setOrderValidatorContract with correct contracts supporting interfaces | ||
| // 'setRoyaltiesRegistry', | ||
| // 'setOrderValidatorContract', | ||
| 'setTrustedForwarder', |
There was a problem hiding this comment.
TODO new tests needed using correct contracts that have the required interfaces
atkinsonholly
force-pushed
the
feat/marketplace-bundle-type
branch
2 times, most recently
from
4ec4a1f
to
f069820
Compare
capedcrusader21
force-pushed
the
feat/marketplace-bundle-type
branch
from
4414e33
to
0082e5c
Compare
feat: bundle as AssetClass
🚨 Report Summary
For more details view the full report in OpenZeppelin Code Inspector |
capedcrusader21
force-pushed
the
feat/marketplace-bundle-type
branch
from
1443dc7
to
375d1ee
Compare
capedcrusader21
force-pushed
the
feat/marketplace-bundle-type
branch
from
375d1ee
to
2a20690
Compare
…tracts-and-test fix: marketplace mock contracts and test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Bundle feature in
packages/marketplace:enum AssetClasspackages/landpackages/deploy