Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: allow ts 5 as a peer dep #226

Merged
merged 2 commits into from
Sep 15, 2023
Merged

chore: allow ts 5 as a peer dep #226

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
77c85e4
chore: allow ts 5 as a peer dep
wdoconnell Sep 15, 2023
264897c
chore: support peerdep ts >= 4.9
wdoconnell Sep 15, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"name": "protoc-gen-ts",
"description": "Compile protocol buffers descriptors to Typescript.",
"version": "0.8.7",
"version": "0.8.8",
"license": "MIT",
"author": {
"email": "[email protected]",
Expand All @@ -26,7 +26,7 @@
},
"peerDependencies": {
"google-protobuf": "^3.13.0",
"typescript": "4.x.x"
"typescript": "4.x.x || 5.x.x"
Copy link

@drbild drbild Sep 15, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd suggest >= 4.9.x instead, to exactly match the runtime check. It requires at least 4.9 and would allow a future 6.x.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@drbild Good point - thanks. Updated.

},
"devDependencies": {
"@bazel/bazelisk": "^1.9.0",
Expand Down
Loading