Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: implement Value::TryInto and Reference::TryInto for class vec #221

Merged
merged 1 commit into from
Jan 19, 2025

Conversation

brianheineman
Copy link
Contributor

No description provided.

@github-actions github-actions bot added the enhancement New feature or request label Jan 19, 2025
Copy link
Contributor

github-actions bot commented Jan 19, 2025

🐰 Bencher Report

Branchimpl-class-vec-try-into
Testbedlocalhost

⚠️ WARNING: No Threshold found!

Without a Threshold, no Alerts will ever be generated.

Click here to create a new Threshold
For more information, see the Threshold documentation.
To only post results if a Threshold exists, set the --ci-only-thresholds CLI flag.

Click to view all benchmark results
BenchmarkLatencynanoseconds (ns)
from_bytes📈 view plot
⚠️ NO THRESHOLD
24,545.00
load_hash_map📈 view plot
⚠️ NO THRESHOLD
372.18
load_invalid_class📈 view plot
⚠️ NO THRESHOLD
27,724.00
runtime_v11📈 view plot
⚠️ NO THRESHOLD
5,710,300.00
runtime_v17📈 view plot
⚠️ NO THRESHOLD
6,538,800.00
runtime_v21📈 view plot
⚠️ NO THRESHOLD
7,291,600.00
runtime_v8📈 view plot
⚠️ NO THRESHOLD
20,107,000.00
to_bytes📈 view plot
⚠️ NO THRESHOLD
19,418.00
to_string📈 view plot
⚠️ NO THRESHOLD
124,380.00
verify📈 view plot
⚠️ NO THRESHOLD
923.88
🐰 View full continuous benchmarking report in Bencher

Copy link

codecov bot commented Jan 19, 2025

Codecov Report

Attention: Patch coverage is 99.26471% with 1 line in your changes missing coverage. Please review.

Project coverage is 96.22%. Comparing base (87a8b73) to head (fdc0f51).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
ristretto_vm/src/thread.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #221      +/-   ##
==========================================
+ Coverage   96.10%   96.22%   +0.11%     
==========================================
  Files         530      530              
  Lines       57879    58003     +124     
==========================================
+ Hits        55627    55812     +185     
+ Misses       2252     2191      -61     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@brianheineman brianheineman force-pushed the impl-class-vec-try-into branch from d5924fe to a559341 Compare January 19, 2025 20:46
@brianheineman brianheineman force-pushed the impl-class-vec-try-into branch from a559341 to fdc0f51 Compare January 19, 2025 20:47
@brianheineman brianheineman merged commit a172ed8 into main Jan 19, 2025
69 checks passed
@brianheineman brianheineman deleted the impl-class-vec-try-into branch January 19, 2025 21:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant