Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: correct bug in java.lang.Class.getDeclaredMethods0() where class constructors were incorrectly returned #226

Merged
merged 1 commit into from
Jan 21, 2025

Conversation

brianheineman
Copy link
Contributor

No description provided.

@github-actions github-actions bot added the fix label Jan 21, 2025
Copy link
Contributor

🐰 Bencher Report

Branchcorrect-get-declared-methods-bug
Testbedlocalhost

⚠️ WARNING: No Threshold found!

Without a Threshold, no Alerts will ever be generated.

Click here to create a new Threshold
For more information, see the Threshold documentation.
To only post results if a Threshold exists, set the --ci-only-thresholds CLI flag.

Click to view all benchmark results
BenchmarkLatencynanoseconds (ns)
from_bytes📈 view plot
⚠️ NO THRESHOLD
25,722.00
load_hash_map📈 view plot
⚠️ NO THRESHOLD
385.97
load_invalid_class📈 view plot
⚠️ NO THRESHOLD
29,463.00
runtime_v11📈 view plot
⚠️ NO THRESHOLD
7,307,300.00
runtime_v17📈 view plot
⚠️ NO THRESHOLD
7,953,500.00
runtime_v21📈 view plot
⚠️ NO THRESHOLD
9,225,700.00
runtime_v8📈 view plot
⚠️ NO THRESHOLD
24,059,000.00
to_bytes📈 view plot
⚠️ NO THRESHOLD
21,084.00
to_string📈 view plot
⚠️ NO THRESHOLD
139,230.00
verify📈 view plot
⚠️ NO THRESHOLD
1,084.10
🐰 View full continuous benchmarking report in Bencher

Copy link

codecov bot commented Jan 21, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.18%. Comparing base (d960618) to head (ab52ea2).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #226      +/-   ##
==========================================
+ Coverage   96.75%   97.18%   +0.43%     
==========================================
  Files         530      530              
  Lines       58451    58628     +177     
==========================================
+ Hits        56552    56976     +424     
+ Misses       1899     1652     -247     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@brianheineman brianheineman merged commit 1ea9d57 into main Jan 21, 2025
70 checks passed
@brianheineman brianheineman deleted the correct-get-declared-methods-bug branch January 21, 2025 02:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant