Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: correct StackFrame offset delta byte to instruction mapping #240

Merged
merged 1 commit into from
Jan 24, 2025

Conversation

brianheineman
Copy link
Contributor

@brianheineman brianheineman commented Jan 24, 2025

Addresses #199

Copy link
Contributor

github-actions bot commented Jan 24, 2025

🐰 Bencher Report

Branchcorrect-stack-frame-byte-to-instruction-mapping
Testbedlocalhost

⚠️ WARNING: No Threshold found!

Without a Threshold, no Alerts will ever be generated.

Click here to create a new Threshold
For more information, see the Threshold documentation.
To only post results if a Threshold exists, set the --ci-only-thresholds CLI flag.

Click to view all benchmark results
BenchmarkLatencynanoseconds (ns)
default_class_loader📈 view plot
⚠️ NO THRESHOLD
6,920,900.00
from_bytes📈 view plot
⚠️ NO THRESHOLD
27,025.00
hello_world📈 view plot
⚠️ NO THRESHOLD
158,030,000.00
load_hash_map📈 view plot
⚠️ NO THRESHOLD
492.13
load_invalid_class📈 view plot
⚠️ NO THRESHOLD
30,416.00
to_bytes📈 view plot
⚠️ NO THRESHOLD
19,910.00
to_string📈 view plot
⚠️ NO THRESHOLD
129,200.00
verify📈 view plot
⚠️ NO THRESHOLD
795.22
vm_init📈 view plot
⚠️ NO THRESHOLD
150,110,000.00
🐰 View full continuous benchmarking report in Bencher

Copy link

codecov bot commented Jan 24, 2025

Codecov Report

Attention: Patch coverage is 92.34450% with 16 lines in your changes missing coverage. Please review.

Project coverage is 97.09%. Comparing base (bacf78d) to head (836fdea).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
ristretto_classfile/src/attributes/attribute.rs 91.25% 16 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #240      +/-   ##
==========================================
- Coverage   97.11%   97.09%   -0.02%     
==========================================
  Files         531      531              
  Lines       58494    58656     +162     
==========================================
+ Hits        56808    56954     +146     
- Misses       1686     1702      +16     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@brianheineman brianheineman force-pushed the correct-stack-frame-byte-to-instruction-mapping branch 3 times, most recently from 4c5d28a to 790fcf9 Compare January 24, 2025 20:19
@brianheineman brianheineman force-pushed the correct-stack-frame-byte-to-instruction-mapping branch from 790fcf9 to 836fdea Compare January 24, 2025 20:26
@brianheineman brianheineman merged commit 850f241 into main Jan 24, 2025
69 of 70 checks passed
@brianheineman brianheineman deleted the correct-stack-frame-byte-to-instruction-mapping branch January 24, 2025 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant