Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor!: update duckdb, rusqlite and sqlite drivers to use <scheme>://<file> format #238

Merged
merged 1 commit into from
Dec 17, 2024

Conversation

brianheineman
Copy link
Contributor

No description provided.

@brianheineman brianheineman force-pushed the update-duckdb-sqlite-and-libsql-url-formats branch from 8ca6fd0 to 2a40535 Compare December 15, 2024 16:00
@brianheineman brianheineman changed the title refactor: update duckdb, libsql, rusqlite and sqlite drivers to use <scheme>://<file> format refactor!: update duckdb, libsql, rusqlite and sqlite drivers to use <scheme>://<file> format Dec 15, 2024
Copy link

github-actions bot commented Dec 15, 2024

🐰 Bencher Report

Branchupdate-duckdb-sqlite-and-libsql-url-formats
Testbedlocalhost

⚠️ WARNING: No Threshold found!

Without a Threshold, no Alerts will ever be generated.

Click here to create a new Threshold
For more information, see the Threshold documentation.
To only post results if a Threshold exists, set the --ci-only-thresholds CLI flag.

Click to view all benchmark results
BenchmarkLatencynanoseconds (ns)
postgres-embedded📈 view plot
⚠️ NO THRESHOLD
822,350,000.00
postgresql-embedded📈 view plot
⚠️ NO THRESHOLD
839,580,000.00
rusqlite📈 view plot
⚠️ NO THRESHOLD
4,373,600.00
sqlite📈 view plot
⚠️ NO THRESHOLD
4,707,700.00
🐰 View full continuous benchmarking report in Bencher

@brianheineman brianheineman force-pushed the update-duckdb-sqlite-and-libsql-url-formats branch 2 times, most recently from 5fceed8 to d146614 Compare December 16, 2024 21:30
Copy link

codecov bot commented Dec 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.70%. Comparing base (2a0da0c) to head (e8e95ce).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #238      +/-   ##
==========================================
+ Coverage   93.68%   93.70%   +0.02%     
==========================================
  Files         107      107              
  Lines       13186    13155      -31     
==========================================
- Hits        12353    12327      -26     
+ Misses        833      828       -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@brianheineman brianheineman force-pushed the update-duckdb-sqlite-and-libsql-url-formats branch 7 times, most recently from e260f2f to 8572929 Compare December 17, 2024 05:00
@brianheineman brianheineman force-pushed the update-duckdb-sqlite-and-libsql-url-formats branch from 8572929 to e8e95ce Compare December 17, 2024 05:26
@brianheineman brianheineman merged commit 8c9e2a9 into main Dec 17, 2024
24 checks passed
@brianheineman brianheineman deleted the update-duckdb-sqlite-and-libsql-url-formats branch December 17, 2024 06:11
@brianheineman brianheineman changed the title refactor!: update duckdb, libsql, rusqlite and sqlite drivers to use <scheme>://<file> format refactor!: update duckdb, rusqlite and sqlite drivers to use <scheme>://<file> format Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant